personalrobotics / ada_feeding

Robot-assisted feeding demos and projects for the ADA robot

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[ROS2] Remove overridden parameters that are set to the default value

amalnanavati opened this issue · comments

As of #146, even if overridden parameters are set to the default value, they stay in ada_feeding/config/ada_feeding_action_servers_currentl.yaml. Instead, in create_action_servers.py, we should add a check for whether their value is the same as the default value, and if so, remove them from self.overridden_parameters. Within self.save_overridden_parameters(), if len(self.overridden_parameters) == 0, save the file with just an empty string within overridden_parameters, same as the current file in the git repo.

The exact way to address this has changed with #172 , but overall it could be helpful to not save a custom parameter if it is the same as the default, for readability.