Remove packages migrated to mil_common
DSsoto opened this issue · comments
We should start removing duplicate packages in the repo.
This is some of what needs to go:
- sub8_perception/*/sub8_vision_lib
- sub8_sonar
- hydrophones
- paulboard
- some of sub8_tools
- some of sub8_msgs
Be sure to reference your PR if you do any of this and/or add to this list.
Is taking care of this on NaviGator right now out of the question? I feel like if we don't it will be a mess to do next year.
Also, I would advise that we merge mil_common #15 before this.
Only if it's a low effort thing, we don't want to sink a lot of time into making NaviGator compatible right now.
Have you even reviewed any of it or commented that it looks good? No one has.
I'm going to make this my pet project for the week. Plan is as follows:
- Remove packages/files duplicated in mil_common
- Use git grep with awk to replace strings like 'sub8_ros_tools' with 'mil_ros_tools'
- Look at diff to verify nothing crazy happened
- Start testing things to see what's broken
I'll open a PR once I get to step 4 to see if anyone notices anything wacky.
Can this be closed now that #216 has been merged?