Gains not used

[Joseph Mirabel]

Gains are not used in the for loop below. @olivier-stasse is this a programming mistake or are they not necessary ?

roscontrol_sot/src/roscontrol-sot-controller.cpp

Line 964 in 0385fe4

 control_toolbox::Pid::Gains gains = ecpdcdata.pid_controller.getGains(); 

[Olivier Stasse]

This branch is incomplete. When in torque mode the proper way to control the joint is given in branch master/devel. Ideally the part inside the loop should go into a joint class encapsulating the roscontrol one. Le lun. 3 juin 2019 à 17:55, Joseph Mirabel <[e-mail]> a écrit :

…

Gains are not used in the for loop below. @olivier-stasse <https://github.com/olivier-stasse> is this a programming mistake or are they not necessary ? https://github.com/stack-of-tasks/roscontrol_sot/blob/0385fe4e4dbc69514e958c23d2928d0f29566f7b/src/roscontrol-sot-controller.cpp#L964 — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#7?email_source=notifications&email_token=AADBXVMKAXAZPAUJVZ4OLTDPYU5H5A5CNFSM4HSJOL22YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4GXKJIDA>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AADBXVL6AKLTQQVOBZVHF2TPYU5H5ANCNFSM4HSJOL2Q> .

[Joseph Mirabel]

Thank. I solved my issues.