kobuki_gazebo not compiling after gazebo_ros_pkgs cleanup

Question

kobuki_gazebo not compiling after gazebo_ros_pkgs cleanup

tfoote opened this issue 7 years ago · comments

Tully Foote commented 7 years ago

There was a dependency cleanup in gazebo_ros_pkgs ros/rosdistro#14563

There's a known issue in catkin
ros/catkin#856

http://build.ros.org/view/Kbin_uX64/job/Kbin_uX64__kobuki_gazebo_plugins__ubuntu_xenial_amd64__binary/47/console

Daniel Stonier · Answer 1 · Sun Apr 23 2017 05:44:36 GMT+0800 (China Standard Time)

@tfoote had a read of all that and managed to reproduce the error locally.

I don't think I can do anything from here though - if the workaround with a config extras cmake module is the right way for now (as demonstrated by @davetcoleman in dummy_gazebo_ws), then should this be applied in gazebo_plugins which still expicitly DEPENDS on GAZEBO (i.e. exports the -lpthread)?

Tully Foote · Answer 2 · Sun Apr 23 2017 06:48:45 GMT+0800 (China Standard Time)

@j-rivero @dirk-thomas Can you comment?

Dirk Thomas · Answer 3 · Sun Apr 23 2017 14:19:08 GMT+0800 (China Standard Time)

I don't have anything to contribute on this. As far as I recall the catkin ticket this was supposed to be addressed within the packages affected somehow. And if a catkin change could be helpful someone wanted to provide a PR for it.

Jose Luis Rivero · Answer 4 · Tue Apr 25 2017 01:06:38 GMT+0800 (China Standard Time)

@j-rivero @dirk-thomas Can you comment?

Dirk is right, we don't count with patching catkin at least in the short term. If @davetcoleman has time to provide a solution that would be great. Otherwise I will revert the change in gazebo_ros_pkgs.

Daniel Stonier · Answer 5 · Tue Apr 25 2017 01:52:43 GMT+0800 (China Standard Time)

If going forward is important, as far as I can tell, we could quickly patch gazebo_plugins with @davetcoleman's workaround (i.e. shift Gazebo from DEPENDS to CFG_EXTRAS in the package exports) or alternatively wait for gazebo_dev to land which does exactly this and depend on that.

Tully Foote · Answer 6 · Tue Apr 25 2017 04:59:32 GMT+0800 (China Standard Time)

@j-rivero I think that reverting until there's a clear recommended path forward is the best path for now.

Jose Luis Rivero · Answer 7 · Tue Apr 25 2017 07:33:40 GMT+0800 (China Standard Time)

while I clean up the mess and provide a decent alternative, here is the revert so we don't make the new kinetic release to wait: ros/rosdistro#14631. Thanks @tfoote @stonier

Dave Coleman · Answer 8 · Tue Apr 25 2017 13:01:35 GMT+0800 (China Standard Time)

This is pretty annoying - that cleanup has now been reverted twice. It was important to me because I was asked to get the Baxter SDK (that uses Gazebo) to have no build warnings, now that it is reverted it is again incorrect and produces the following output:

Warnings   << gazebo_plugins:check /home/dave/ros/current/ws_vicarious/logs/gazebo_plugins/build.check.001.log
CMake Warning at /opt/ros/kinetic/share/catkin/cmake/catkin_package.cmake:166 (message):
  catkin_package() DEPENDS on 'gazebo' but neither 'gazebo_INCLUDE_DIRS' nor
  'gazebo_LIBRARIES' is defined.
Call Stack (most recent call first):
  /opt/ros/kinetic/share/catkin/cmake/catkin_package.cmake:102 (_catkin_package)
  CMakeLists.txt:88 (catkin_package)
CMake Warning at /opt/ros/kinetic/share/catkin/cmake/catkin_package.cmake:166 (message):
  catkin_package() DEPENDS on 'SDF' but neither 'SDF_INCLUDE_DIRS' nor
  'SDF_LIBRARIES' is defined.
Call Stack (most recent call first):
  /opt/ros/kinetic/share/catkin/cmake/catkin_package.cmake:102 (_catkin_package)
  CMakeLists.txt:88 (catkin_package)

Tully Foote · Answer 9 · Thu Apr 27 2017 03:16:36 GMT+0800 (China Standard Time)

Fixed by rollback. Closing.

Jose Luis Rivero · Answer 10 · Thu Apr 27 2017 06:32:04 GMT+0800 (China Standard Time)

This is pretty annoying - that cleanup has now been reverted twice. It was important to me because I was asked to get the Baxter SDK (that uses Gazebo) to have no build warnings, now that it is reverted it is again incorrect and produces the following output:

That is mostly my fault for not being to find a good solution, sorry for that Dave. I hope that by merging ros-simulation/gazebo_ros_pkgs#571 the problems is solved for all the parts.