uf-mil / ros_alarms

Alarm system implementation in ROS

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ALARM SERVER: publish alarm update before calling callback

kev-the-dev opened this issue · comments

We noticed in testing SubjuGator that some alarms can take several seconds to raise. One reason is that the alarm server calls raise/clear callbacks registered in alarm handlers before publishing the update to the rest of the nodes connected. If this callback takes a while (such as calling a service / writing to files), this can create a significant delay in when vital nodes are notified of the change. These callbacks should either be executed async or after the update is published.

Addressed in #33, commit a79d0bf.

#33 has been merged for a while and the amonitor interface seems to have helped reduce alarm lag.