Fix position_control_sample.launch
nyxrobotics opened this issue · comments
Abstract
Specify PID gain in position_control_sample.launch.
How to Reproduce the Bug
Problem due to the Bug
Factors
Suggestion
Can you elaborate on this a little bit more?
The sample velocity_duty_control_sample.launch has PID gains but position_control_sample.launch doesn't.
Since these are PID-controlled samples, gain adjustment is a must.
It is better to specify gain parameters for position_control_sample.launch.
vesc/vesc_hw_interface/launch/velocity_duty_control_sample.launch
Lines 8 to 25 in 3d5e62e
vesc/vesc_hw_interface/launch/position_control_sample.launch
Lines 8 to 19 in 3d5e62e
Fair enough.
Do you have any recommended values or should we use the default values?