``foxy`` and ``galactic`` branch contains breaking changes since last release

Question

``foxy`` and ``galactic`` branch contains breaking changes since last release

ijnek opened this issue 2 years ago · comments

When I branched off foxyand galactic branches, I branched off from the ros2 branch, because that was the dev branch listed in rosdistro for the distributions. However, the ros2 branch contained a significant number of breaking changes, and the foxyand galactic branches shouldn't have been branched off devel.

Should try and revert all the breaking changes in the two branches to get the foxyand galactic branches working and make a release.

Kenji Brameld · Answer 1 · Sat Sep 17 2022 17:44:15 GMT+0800 (China Standard Time)

I've gone through all PRs that were merged since the last release in Foxy and Galactic.

Changes that need to be reverted:

Changes that don't have to be reverted:

Akash · Answer 2 · Mon Sep 19 2022 03:31:50 GMT+0800 (China Standard Time)

Is there a reason to revert #421 and #422 as well? After the revert, builds do not work when using a Boost 1.67 or newer, as explained in #390 (comment)

from this document:

Note that Boost Python components require a Python version suffix (Boost 1.67 and later), e.g. python36 or python27 for the versions built against Python 3.6 and 2.7, respectively. This also applies to additional components using Python including mpi_python and numpy. Earlier Boost releases may use distribution-specific suffixes such as 2, 3 or 2.7. These may also be used as suffixes, but note that they are not portable.

Kenji Brameld · Answer 3 · Mon Sep 19 2022 06:49:41 GMT+0800 (China Standard Time)

Hi @Ace314159, sorry for the inconvenience the reversion has caused and thanks for reporting it. Let's get it resolved.

Here's the original reasons:
#419 was reverted because that was the PR that was breaking API in foxy and galactic.
#421 was reverted because it depended a lot on changes from #419
#422 was reverted because it was fixing mistakes in #421.

However, now looking at #390, this is suggesting to me that the foxy/galactic build on windows might fail after the reversions I've made.

Could you describe the platform / distribution that's failing? And also, which branch you're building from source, (or whether you are using a binary).

Akash · Answer 4 · Mon Sep 19 2022 07:10:56 GMT+0800 (China Standard Time)

Thanks for the prompt response! I am building from source using the foxy branch on Windows.

Kenji Brameld · Answer 5 · Mon Sep 19 2022 07:22:37 GMT+0800 (China Standard Time)

Great, thanks for the information. Could you try out the branch: foxy-with-boost-python-fix I just put up?
It has changes from #390 applied, which was easier to port across than the changes from #421.

Akash · Answer 6 · Mon Sep 19 2022 07:44:38 GMT+0800 (China Standard Time)

It works! Thanks for the quick turnaround!

Kenji Brameld · Answer 7 · Tue Sep 20 2022 20:48:25 GMT+0800 (China Standard Time)

I'm going to re-open this issue until a release has been made. I'm currently trying to figure out how to get a pre-release test going before I make another release.

Kenji Brameld · Answer 8 · Thu Oct 13 2022 06:12:04 GMT+0800 (China Standard Time)

Releases were made.

However, I've been reported that the backport to galactic broke Galactic builds on RHEL: https://build.ros2.org/job/Gbin_rhel_el864__cv_bridge__rhel_8_x86_64__binary/

I've reverted the release to an older version until we resolve this. Let's track this issue here.

Kenji Brameld · Answer 9 · Thu Oct 13 2022 06:35:06 GMT+0800 (China Standard Time)

@Ace314159 could you review #495 please?

Akash · Answer 10 · Thu Oct 13 2022 06:44:55 GMT+0800 (China Standard Time)

It looks good to me! Just wasn't sure about the COMPONENTS thing I mentioned.

Kenji Brameld · Answer 11 · Sat Oct 15 2022 21:58:56 GMT+0800 (China Standard Time)

Closing, as should be fixed with #495 🤞