rafelafrance / traiter

Extract information from natural history annotations

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Incorrect units when units separated from value by another measurement

tucotuco opened this issue · comments

Given the input string "SV 1.4, TAIL 1.0 CM. HATCHLING"

the output is lengthinmm:1.4 is_inferred:1 standard length type: "snout-vent length"

The expected output is lengthinmm:14 is_inferred:0 standard length type: "snout-vent length"

The pattern of having the unit separated from the value in this way seems not to be covered.

commented

I disagree with this one. I think there is no evidence as to units for
this one, despite the tail units.

On Tue, Aug 9, 2016 at 1:32 PM, John Wieczorek notifications@github.com
wrote:

Given the input string "SV 1.4, TAIL 1.0 CM. HATCHLING"

the output is lengthinmm:1.4 is_inferred:1 standard length type:
"snout-vent length"

The expected output is lengthinmm:14 is_inferred:0 standard length type:
"snout-vent length"

The pattern of having the unit separated from the value in this way seems
not to be covered.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#9, or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcc7HYKqR1xYSWjD_2fZMYEi0cI2hsUks5qeLmcgaJpZM4JgU5o
.

I sincerely doubt the SV could be 1.4mm on a vertebrate, especially with a tail of 1cm. Though it may be valid not to assume the pattern can always hold.

commented

Ok good point - that is a strong inference! :)

On Tue, Aug 9, 2016 at 2:57 PM, John Wieczorek notifications@github.com
wrote:

I sincerely doubt the SV could be 1.4mm on a vertebrate, especially with a
tail of 1cm.


You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#9 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AAcc7Je70Z_xndLmNqOez0vwWy7lZHxEks5qeM2ogaJpZM4JgU5o
.

commented

It may be possible to pick this up in the new post processing step.

commented

Dead issue closing