personalrobotics / pr_assets

OpenRAVE data used by the Personal Robotics Lab at CMU.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

<Data> versus <collision>

jslee02 opened this issue · comments

It seems the KinBody files in this repo use <Data> for collision mesh, but the spec uses <collision> instead. Is this intentional or an oversight?

Related PR: Aikido #102

Since <collision> is the spec, I would suggest using it rather than <Data> unless there is a compelling reason not to do.

This is not ambiguous. See personalrobotics/aikido#102 (comment).

I am fine with switching to <collision>. However, I am skeptical of putting too much faith into that specification. In practice, the only thing that matters is what is implemented in the code. 😢