personalrobotics / aikido

Artificial Intelligence for Kinematics, Dynamics, and Optimization

Home Page:https://personalrobotics.github.io/aikido/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

ConcreteManipulator should be inheriting from ConcreteRobot?

gilwoolee opened this issue · comments

Currently,

  • Manipulator inherits Robot
  • ConcreteRobot inherits Robot
  • ConcreteManipulator inherits Manipulator

the only difference between Manipulator and Robot is that Manipulator has getHand class.
I think above inheritance makes sense conceptually, but code-wise, there's a lot of code duplicates between ConcreteManipulator and ConcreteRobot, esp. regarding TSR related methods.

I think we need to add ConcreteRobot to ConcreteManipulator's parent class list, i.e.

  • ConcreteManipulator inherits Manipulator and ConcretRobot

Resolved by the Robot API overhaul (#593 )