ConcreteManipulator should be inheriting from ConcreteRobot?
gilwoolee opened this issue · comments
Currently,
Manipulator
inheritsRobot
ConcreteRobot
inheritsRobot
ConcreteManipulator
inheritsManipulator
the only difference between Manipulator
and Robot
is that Manipulator
has getHand
class.
I think above inheritance makes sense conceptually, but code-wise, there's a lot of code duplicates between ConcreteManipulator
and ConcreteRobot
, esp. regarding TSR related methods.
I think we need to add ConcreteRobot
to ConcreteManipulator
's parent class list, i.e.
ConcreteManipulator
inheritsManipulator
andConcretRobot
@brianhou @aditya-vk @sniyaz @egordon Any thoughts?
Resolved by the Robot API overhaul (#593 )