Formatting checks disabled (possible erroneous?)

Question

Formatting checks disabled (possible erroneous?)

aditya-vk opened this issue 5 years ago · comments

Aditya Vamsikrishna Mandalika commented 5 years ago

Two issues:

Format checks are currently disabled. I think this was intentional during the shift to bionic and clang-format-6.0. We need to bring it back.
I am not sure if the following issue is local to me (@madan96 can you please verify). a) Master still seems to need formatting corrections. And, b) On running the formatting command, #521 seems to still fail. For instance src/rviz/InteractiveMarkerViewer.cpp Line 206 is never corrected in its indentation. I have clang-format-6.0 on bionic.

Rishabh Madan · Answer 1 · Wed Oct 02 2019 12:46:10 GMT+0800 (China Standard Time)

Yeah, I just checked and there seem to be some src files in rviz, perception and control subdirectories that still require formatting changes. Not sure how they got left out, there is no PR affecting these files, after #549 that was merged into master after this so I think that's where the problem is.

Rishabh Madan · Answer 2 · Thu Oct 03 2019 07:49:28 GMT+0800 (China Standard Time)

@brianhou Should we run check-format for all builds or at least BIONIC_CATKIN_FULL_RELEASE?

Brian Hou · Answer 3 · Fri Oct 04 2019 02:36:57 GMT+0800 (China Standard Time)

We only need to check the formatting on one build.