openhwgroup / core-v-verif

Functional verification project for the CORE-V family of RISC-V cores.

Home Page:https://docs.openhwgroup.org/projects/core-v-verif/en/latest/index.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Use of two-state variables in RVFI Agent

MikeOpenHWGroup opened this issue · comments

Hi @MarioOpenHWGroup, you are getting this issue because git says you are the author of this code.

In uvma_rvfi_tdefs.sv there is a packed struct called st_rvfi that is used to create arguments to a couple of DPI functions to implement Spike Tandem operation.

All of the members of this struct are longint unsigned which are two-state variables. In general, two-state variables are to be avoided as uninitialized data will be mapped to zero which may mask problems.

Can these be implemented as logic[63:0]?

I think so, it should be a problem at all 👍