fails to compile with the latest version of rviz
wjwwood opened this issue · comments
For example:
I believe the root cause of this is that the "default_plugin" is no longer included in rviz's _LIBRARIES variable, but moveit_ros_benchmark_gui uses headers from the default plugin and so it needs to link against them. There is now a cmake variable called rviz_DEFAULT_PLUGIN_LIBRARIES which you can add to your target_link_libraries which will contain the default plugin. I recommend that this variable be used to fix the current compilation problems.
See:
Can anyone try with ros-visualization/rviz#983?
This doesn't fix it for me. The problem is that the rviz extras wants the generated file and thus fails before linking during cmake already.
CMake Error at .../devel/share/rviz/cmake/rviz-extras.cmake:2 (include):
include could not find load file:
.../devel/share/rviz/cmake/default_plugin_location.cmake
Call Stack (most recent call first):
.../devel/share/rviz/cmake/rvizConfig.cmake:190 (include)
/opt/ros/indigo/share/catkin/cmake/catkinConfig.cmake:75 (find_package)
moveit_ros/benchmarks_gui/CMakeLists.txt:19 (find_package)
I see, let me try to address that.
I added ros-visualization/rviz@91ba11a to try and address that. Can you give that a try?
It did compile with catkin_make. However only after multiple runs with --force-cmake. On the first run I'm getting linker errors, because it's not linking the library.
@dornhege is that from a clean build that it fails on the first pass?
Yes, after I removed build/ and devel/.
@dornhege can you send me a .rosinstall file for your workspace?
The .rosinstall is attached, where I manually checked out your rviz commit.
After a second pass with catkin_make --force-cmake it build.
I can reproduce that issue and I think I understand why it is a problem. I changed the way I expose it with ros-visualization/rviz@610ecf5. I'll just have to remember to update that when I change the default plugin's library name in Kinetic.
I'm rebuilding now to test it.
It seems to build for me now. I'm gonna merge the rviz pr and prepare for another release. Let me know if you see anymore issues with it. Thanks for helping me test it.
Nice work. Builds fine for me to.
@dornhege FYI, I have made a slight improvement after thinking about it more and seeing a failure during one of the repeated builds of the moveit workspace: ros-visualization/rviz#984
Is this resoloved? I'm still seeing a build failure.
