API request: return NULL from parasail_sequences_from_file upon error?

Question

API request: return NULL from parasail_sequences_from_file upon error?

jvkersch opened this issue 5 years ago · comments

Joris Vankerschaver commented 5 years ago

The function parasail_sequences_from_file does an exit(1) when something goes wrong (out of memory, sequence file not found, etc), but that makes it a bit cumbersome to use in library code. Would it be possible to have this function return NULL instead, possibly with an error message set?

Jeff Daily · Answer 1 · Thu May 09 2019 22:56:58 GMT+0800 (China Standard Time)

Oh no that's terrible, sorry! Yes I believe I can fix. Happy to accept PRs too ;-). Might get done faster that way.

Jeff Daily · Answer 2 · Tue May 14 2019 02:48:40 GMT+0800 (China Standard Time)

New feature branch to address this issue: feature/no_exit
https://github.com/jeffdaily/parasail/tree/feature/no_exit

Joris Vankerschaver · Answer 3 · Tue May 14 2019 04:29:45 GMT+0800 (China Standard Time)

Thanks @jeffdaily for the quick turnaround, and for making an already great library even better!

I had looked at the code a bit over the weekend, but I didn't feel confident enough to make a PR.

Jeff Daily · Answer 4 · Thu Apr 16 2020 00:50:13 GMT+0800 (China Standard Time)

This feature will finally release with version 2.4.2.