ihmcrobotics / euclid

Vector math, geometry, reference frame, and shapes 2D & 3D

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Calling FrameConvexPolygon2D.setIncludingFrame() doesn't set frame with empty vertex.

rjgriffin42 opened this issue · comments

The following case current fails:

There are two random polygons, in random frames, polygonA and polygonB.

polygonA.clear();
polygonB.clear();
polygonB.setIncludingFrame(polygonA);
assert(polygonA.epsilonEquals(polygonB, 1e-5);

This fails because of a reference frame mismatch.

Note that a way around this is

polygonA.clear();
polygonB.clear();
polygonB.setIncludingFrame(polygonA.getReferenceFrame(), polygonA);
assert(polygonA.epsilonEquals(polygonB, 1e-5);

This isn't exactly a desirable work around, though.

Oh wow, I'll fix that, thanks!

Addressed in a2ac895