Giters

commaai / opendbc

democratize access to car decoder rings

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Make can_valid consider checksums and counters

sshane opened this issue · comments

commented

In this segment (6f63165f17c0e270|2022-03-19--23-09-55--92), a Genesis had a controls mismatch due to the car sending a message with an invalid checksum so panda stopped allowing messages but we don't check this in the CAN parser.

  • Consider checksums and counters (need flags to ignore checksums in certain cases? eg. legacy HKG)
  • Add checksum for Hyundai