Giters

Unity-Technologies / com.unity.demoteam.digital-human

Library of tech features used to realize the digital human from 'The Heretic' and 'Enemies'.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Please allow external update of SkinAttachmentTarget

qlee01 opened this issue · comments

commented

Hi, thanks for the great work!
Currently, SkinAttachmentTarget is being updated on BeginFrameRendering / EndFrameRendering. While this might work for many use cases, it breaks as soon as overriding a SkinnedMeshRenderer (e.g. for Softbody simulation or Dual Quaternion Skinning). In this case the mesh needs to be changed in BeginContextRendering, e.g. after the skin attachment has been done.
Best solution would be to offer an explicit update mode, where an outside script would trigger the AfterGpuSkinningCallback (or ResolveSubjects). This would not break anything, but would allow more elaborate use cases which go beyond using the outdated linear blend skinning of SMR.

Thanks!