PX4 / PX4-user_guide

PX4 User Guide

Home Page:https://docs.px4.io/main/en/index.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Error in the image of Hige-Level Software Architecture

federicociresola opened this issue · comments

I noticed that this image has not been updated after the v1.14 release because it still contains the reference of FastRTPS but
now we are using the uXRCE-DDS

https://github.com/PX4/PX4-user_guide/blame/e62e933def6da6655bfec5d21fba0535deacf4d3/en/concept/architecture.md#L20

Thanks @federicociresola

@beniaminopozzan Would you be happy with a fix to the diagram like this:
image

The bit I am not sure about is the "CDR serialization". I mean should we be talking about ROS2 here?

@hamishwillee , according to https://www.eprosima.com/index.php/products-all/eprosima-micro-xrce-dds (architecture section), I would put micro CDR serialization or nothing. Just "via UART/UDP" like on the MAVLink block.

We don't mention the possible targets of MAVLink, then in my opinion we shuld not talk about ROS2.

All done thanks. Fixed by #2896