[dds] Final micrortps cleanup before v1.14.0 release
beniaminopozzan opened this issue · comments
As discussed during today's Community Q&A in some pages the documentation is still referring to the removed micrortps_bridge (even if most of the transition to microdds has been completed / is happening now).
The remaining pages/sections are
- Ethernet setup - ros section. The section has already been updated and it shows that micrortps is no longer supported.
update: Fixed by #2349 - ROS (1) via ROS 2 Bridge. The page has already been updated and it shows that micrortps is no longer supported.
Update: ROS (1) via ROS 2 Bridge has been removed - #2418 - Simulation main page. Here the
micrortpsis just mentioned.
Update: Associated PR #2396 - Multi vehicle simulation with Gazebo Classic. The page has already been updated and it shows that micrortps is no longer supported.
Update: Associated PR #2396
Thanks @beniaminopozzan . The comments above could be taken to mean that the needed work has been done. This is not the case - the minimal work to add a note indicating that documentation is broken has been done, but the documentation itself is still broken.
Now some of these I think we can leave in this state, but others should be easy to fix - for example you could fix https://docs.px4.io/main/en/advanced_config/ethernet_setup.html#ros2-setup-example without even testing it - mostly just by updating the agent startup string and pointing to the existing docs.
For https://docs.px4.io/main/en/ros/ros1_via_ros2.html#ros-1-via-ros-2-bridge-user-guide Nuno suggested perhaps doing this using some new eProsima component that I can't remember the name of. That would require testing.
Were you thinking of looking at these. I do what is a priority as I get there.
Note also that I do not back fill docs. ONce we take a cut of PX4 docs that's it, the PX4 1.14 docs are more or less set in stone.
The comments above could be taken to mean that the needed work has been done. This is not the case - the minimal work to add a note indicating that documentation is broken has been done, but the documentation itself is still broken.
@hamishwillee that's sadly true, my bad choice of words.
Were you thinking of looking at these
Yes!
Note also that I do not back fill docs. ONce we take a cut of PX4 docs that's it, the PX4 1.14 docs are more or less set in stone.
Then I should hurry!
Thanks @beniaminopozzan . Normally I'd say "don't worry about it, PX4 will release about a year after we say it will". But there seems to be some genuine progress happening!
I think its time I ran a link checker again to work out what else has changed and not been documented.
This issue has been mentioned on Discussion Forum for PX4, Pixhawk, QGroundControl, MAVSDK, MAVLink. There might be relevant details there:
https://discuss.px4.io/t/px4-maintainers-call-april-04-2023/31415/1
Hey @beniaminopozzan as discussed on today's maintainer call let's remove the ROS 1 to ROS 2 bridge page from our documentation
Thanks @mrpollo , here is the PR.
Did you work out what to do about the ROS2 with MAVROS story?
EDITED. Yes, for now we will add a note in the top of the ROS2 page about options.
Closing as completed, all micrortps references have been removed.
Many thanks @beniaminopozzan