CMake Modernization
KBentley57 opened this issue · comments
Hi Everyone,
I'm very interested in this project. I've primarily been a user of Colmap, but have been searching for a way to speed up the global bundle adjustment. I only came across the paper by accident. The results look very promising! I'd like to contribute where I can.
Would you mind if I spent a few minutes modernizing the CMake?
Hi KBentley57,
Thanks for your comments! We indeed are planning to integrate MegBA into Colmap and we are very glad to invite you to participate in MegBA. What kind of collaboration platform (e.g. Google Group) would you like? We may have some discussion later for better collaboration on the Colmap integration feature.
As you mentioned the demand for "modernizing the CMake", I may not get your point. Would you please describe it in more detail?
Best regards,
Jie
Jie,
That would be wonderful. I and a few others I work with would be more than willing to help. Let's get an email communication started where we can discuss it more. My personal email address is kwbent01@gmail.com. If you wouldn't mind sending me an email, we can continue the colmap discussion there.
Regarding the build system - there's nothing wrong with it per se. I'd just like to submit a PR when I'm done making it a little more robust for different linux distros, as well as adding installation targets, exports, and other necessary modules so that others have a higher rate of success on their first attempt at compilation. I anticipate that this project will at some point have a much wider audience than it does now, and making sure it builds easily reduces a barrier to participation.
Thanks for the reply, I look forward to hearing from you.
Kyle
Hi Kyle,
So glad to hear that so many people would like to join the project, we think we could make the project robust and powerful together. I agree with your suggestion to make the compilation robust. Today I just reformat the entire code in Google-style using clang-format. So it may seem that a lot of files has been changed, but don't worry.
In addition, I have sent you an email using my personal address jieren9806@gmail.com. Hope we can make the world different :)
Best regards,
Jie
@KBentley57 @JieRen98 Hi, Have you integrated MegBA into colmap? What is the progress? Are you considering open source?
Thanks for your comment!
Currently, I am fully focusing on designing sparse solvers to beat solvers like CHOLMOD. So the colmap integration plan is still on my todo list :-(
Sorry for the very slow progress.