Safeguard againsts lab errors in run creation
mgcam opened this issue · comments
Runs created in NPG, but then put on a different instrument.
Extension to the staging daemon to flag this king of swap: check that the instrument id in the RunParameters.xml is consistent with the value in the tracking database, also check the slot is correct. An error in a mismatch with existing in the database run folder name and glob will prevent assigning the same run id (as Experiment Name) to multiple runs
Also, limit these updates to runs which are in a run state "run pending" or "run in progress"?
If the run id is specified incorrectly, in particular if the value entered corresponds to an older run or a run on a different instrument we should flag this as an error and not update the DB. We should be able to infer the correct date and instrument from the runfolder name.
As an example of what can go wrong, we had a recent run where the specified run id was for a run from 2011 which had been cancelled so we deleted the runfolder while the run was still in progress.