Issue with empty string as name
JasperCraeghs opened this issue · comments
Given the following json.
{ "signal":[
{"name": "", "wave": "13.========4.1", "data": ["StartBit", "b7", "b6", "b5", "b4", "b3", "b2", "b1", "b0", "StopBit"]},
{"name": "Frame format", "wave": "1=.==....|=3=..1", "data": ["Break", "ID", "DATA", "CRC", "ACK", "End of frame"]}
]}
One signal has an empty string as name, which causes the signal to not get generated. It only takes up some vertical space:
If that were the only signal, only a vertical dashed line would get generated by wavedrompy.
wavedrom allows an empty string as name. I think it would be nice if wavedrompy would support this as well.
Interesting.. I think I can fix that tomorrow, thanks!
Fixed in ac20aba. Thanks again for reporting!
Can you confirm that the fix worked?
Yes, the fix worked. Thank you! When do you plan to make a new release? I am patiently waiting on one.
There will be one today and another one next week. I am currently bringing in recent upstream changes.
I have just released 2.0.2 and plan to release 2.1.2 soon.
@JasperCraeghs and @MutantPlatypus can you both please check if wavedrom>2.0.2 works for you? Thanks!
It works for me.
Works for me, too.
