Transition from node12 to node16

[Jean-Christophe Fillion-Robin]

As described in this post¹, node12 is being deprecated in favor of node16:

We plan to migrate all actions to run on Node16 by Summer 2023. We will monitor the progress of the migration and listen to the community for how things are going before we define a final date.
To raise awareness of the upcoming change, we are adding a warning into workflows which contain Actions running on Node 12. This will come into effect starting on September 27th.

Reviewing the changelogs of other GitHub Actions like checkout² or cache[^3], the transition to node16 corresponded to a major release.

I suggest we follow the same pattern and release v2

Footnotes

1. https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/ ↩

2. https://github.com/actions/checkout/blob/main/CHANGELOG.md#v300 and https://github.com/actions/checkout/commit/8f9e05e482293f862823fcca12d9eddfb3723131 ↩

[Sebastian Spier]

Sounds good!

Just curious about the general approach to release strategy here:
If the upgrade from node12 to node16 does not introduce breaking changes in screenshot-website, technically we would not have to do a major version upgrade, would we?

As an aside: The [^3] reference is missing above.

[Jacob Matson]

would love to see this updated to most recent version of node with LTS (20, iirc).

[Sebastian Spier]

@matsonj do you have experience with this type of upgrade, and could you help with this?

[Sebastian Spier]

Just adding the reference by GitHub about their GitHub Actions transitioning to node 20 now:
https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/