- keylime
The data are structured in flexible metadata format (fmf). Individual tests are supposed to be executed either via Test management tool (singlehost tests only) or bkr workflow-tomorrow via Nitrate.
See:
Every important change to tests should undergo a review within a pull request.
Small, trivial changes may be committed directly to the master branch. As a typical trivial change one may consider a metadata update (updated tags, adjust, ..) or typo fixes, updated to comments and formating changes.
All changes to the test logic (changes of expected output, expected exit codes) need to be reviewed.
It is recommended to push new tests via PR with review as well as a check for covering all the agreed acceptance criteria is more than welcome.
The review can be done by any member of the team. However, it is recommended to ask the devel counterpart as they could judge the test expectations according to the actual code change. Asking another QE person, on the other hand, will ensure to keep the test coding style as consistent as possible.
The merge itself should be done based on the accepted reviews. It is recommended to let the original requestor to merge the PR as they may want to do some refinements, e.g. squash some commits which were added during the review process.
It is also important to make sure that the Nitrate references are resynced (tmt tests export --nitrate .) to update the reflect the change form the previous location (branch) to the final one.