stormwatch / hw-tdd-rspec

Revised RSpec assignment for adding Director field to Movies model in RottenPotatoes app

TDD with RSpec

In this assignment you will use a combination of Acceptance and Unit/Functional tests with the Cucumber and RSpec tools to add a "find movies with same director" feature to RottenPotatoes.

**NOTE: Do not clone this repo to your workspace. Fork it first, then clone your fork.

Learning Goals

After you complete this assignment, you should be able to:

• Create and run simple Cucumber scenarios to test a new feature

• Use RSpec to create unit and functional tests that drive the creation of app code that lets the Cucumber scenario pass

• Understand where to modify a Rails app to implement the various parts of a new feature, since a new feature often touches the database schema, model(s), view(s), and controller(s)

• Use continuous integration with Travis to continuously monitor test coverage and passing status

Specifically, you will add two features to RottenPotatoes: "User can include name of Director with a movie", and "Given a movie with a director, user can search for other movies with same director". You will use TDD to develop these features and achieve 100% statement coverage (C0) of RSpec tests for the features.

Introduction and Setup

Travis CI: continuous integration and test coverage

In this assignment you'll use Travis to continuously monitor if your tests are passing and what your C0 test coverage is. If you don't already have a free Travis account, create one; then add your fork of this repo to the "watched repos". You will have to confirm on GitHub that Travis should be allowed access to your public repo; this allows Travis to be notified when any code pushes occur.

The idea behind CI is simple: it can be set up to automatically run tasks related to testing and verification each time you push new code. For Rails apps that have been set up with Cucumber and RSpec, the tasks rake cucumber and rake rspec run all of the Cucumber scenarios and RSpec tests, respectively. We will also include an additional task that measures test coverage, by tracking which lines of which files in your app are actually "touched" by any test code.

1. On the Travis CI website, locate the instructions to add a "Travis CI badge" to this README.md file. Commit and push the modified README.md and verify you can see the Travis badge render correctly on the front page of your repo.

2. Take a look at the .travis.yml file in this project, which gives Travis instructions on what to do each time code is pushed to GitHub. Satisfy yourself that you understand the meaning of each directive in that file.

3. In particular, notice the lines that collect test coverage information and send it to CodeClimate, a hosted code-analysis service, to report on your test coverage. To set this up: Setup a free account (we recommend using "Sign In With GitHub") on codeclimate.com, and add the repo for this homework. Go to the repo's settings in CodeClimate, select the Test Coverage set of options, and copy the CodeClimate Test Reporter ID (a long hexadecimal string). Copy this string to the .travis.yml file as the value for the global option CC_TEST_REPORTER_ID. If you don't do this step, Travis will be unable to report test coverage results to CodeClimate.

Part 0: Setup - ensure tests run locally

Clone this repo to your development environment, make sure you have the necessary gems installed, and do the necessary configuration to install Cucumber and RSpec:

bundle install --without production
bundle exec rake db:migrate
rails generate cucumber:install capybara 
rails generate cucumber_rails_training_wheels:install 
rails generate rspec:install 

1. You can double-check if everything was installed by running bundle exec rake rspec and bundle exec rake cucumber.
   They should pass without any errors. We have provided some Cucumber scenarios in features/ and a subset of the RSpec tests you'll need in spec/.

2. Next, set up test coverage collection. Add the following code BEFORE ANYTHING ELSE ON LINE ONE of both spec/rails_helper.rb and features/support/env.rb:

require 'simplecov' 
SimpleCov.start 'rails' 

Now whenever you run rspec or cucumber, SimpleCov will generate a coverage report in a directory named coverage/. SimpleCov can intelligently merge the results, so running the tests for Rspec does not overwrite the coverage results from SimpleCov and vice versa. Verify that coverage reporting is working.

1. When you're satisfied that the tests and coverage reporting work locally, commit and push all your changes, then head over to travis-ci.org. You should see that a build (continuous integration run) has begun; since there are no tests yet, it should run very quickly. In particular, inspect the output to make sure the process of collecting test coverage results and sending them to CodeClimate was successful.

2. Finally, check CodeClimate for the results of analyzing both code quality and test coverage on your app. For test coverage, you can click on the name of any file in CodeClimate, then click the Code tab, then check the Coverage box. Lines that were "touched" by some test will be highlighted.

Part 1: add a Director field to Movies

Create and apply a migration that adds the Director field to the movies table. The director field should be a string containing the name of the movie's director. HINT: use the add_column method of ActiveRecord::Migration to do this.

Remember that once the migration is applied, you also have to do rake db:test:prepare to load the new post-migration schema into the test database!

Remember to add the new director attribute to the list of movie attributes allowed in params, in the movie_params method in movies_controller.rb.

Part 2: use Acceptance and Unit tests to get new scenarios passing

We've provided three Cucumber scenarios to drive creation of the happy path of Search for Movies by Director. The first lets you add director info to an existing movie, and doesn't require creating any new views or controller actions (but does require modifying existing views, and will require creating a new step definition and possibly adding a line or two to features/support/paths.rb).

The second lets you click a new link on a movie details page "Find Movies With Same Director", and shows all movies that share the same director as the displayed movie. For this you'll have to modify the existing Show Movie view, and you'll have to add a route, view and controller method for Find With Same Director.

The third handles the sad path, when the current movie has no director info but we try to do "Find with same director" anyway.

Going one Cucumber step at a time, use RSpec to create the appropriate controller and model specs to drive the creation of the new controller and model methods. At the least, you will need to write tests to drive the creation of:

• a RESTful route for Find Similar Movies (HINT: use the 'match' syntax for routes as suggested in "Non-Resource-Based Routes" in Section 4.1 of ESaaS). You can also use the key :as to specify a name to generate helpers (i.e. search_directors_path) http://guides.rubyonrails.org/routing.html

Note: you probably won't test this directly in rspec, but a line in Cucumber or rspec will fail if the route is not correct.

• a controller method to receive the click on "Find With Same Director", and grab the id (for example) of the movie that is the subject of the match (i.e. the one we're trying to find movies similar to)

• a model method in the Movie model to find movies whose director matches that of the current movie. Note: This implies that you should write at least 2 specs for your controller:

1. When the specified movie has a director, it should...

2. When the specified movie has no director, it should ...

and 2 specs for your model:

1. it should find movies by the same director and

2. it should not find movies by different directors.

It's up to you to decide whether you want to handle the sad path of "no director" in the controller method or in the model method, but you must provide a test for whichever one you do. Remember to include the line require 'rails_helper' at the top of your *_spec.rb files.

You may find this RSpec cheat sheet helpful.

Improve your test coverage by adding unit tests for untested or undertested code. Specifically, you can write unit tests for the index, update, destroy, and create controller methods.

Submission:

Here are the instructions for submitting your assignment for grading. Submit a zip file containing the following files and directories of your app:

• app/ config/ db/migrate features/ spec/ Gemfile Gemfile.lock

If you modified any other files, please include them too. If you are on a *nix based system, navigate to the root directory for this assignment and run

rottenpotatoes/config/ rottenpotatoes/db/migrate
rottenpotatoes/features/ rottenpotatoes/spec/ rottenpotatoes/Gemfile
rottenpotatoes/Gemfile.lock ```

This will create the file hw5.zip, which you will submit.

IMPORTANT NOTE: Your submission must be zipped inside a rottenpotatoes/
folder so that it looks like so:

``` $ tree .  └── rottenpotatoes
    ├── Gemfile ├── Gemfile.lock ├── app ...