stepjam / RLBench

A large-scale benchmark and learning environment.

Home Page:https://sites.google.com/corp/view/rlbench

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

BUG: assertion condition mismatching

AlbertTan404 opened this issue · comments

At gripper_action_modes.py line 61, the compound inequality mismatches the assertion:

if 0.0 > action[0] > 1.0:  # which is equivalent to 0.0 > action[0] AND action[0] > 1.0
    raise InvalidActionError(
        'Gripper action expected to be within 0 and 1.')

which should be:

if 0.0 > action[0] or action[0] > 1.0:
    raise InvalidActionError(
        'Gripper action expected to be within 0 and 1.')

or

if not 1.0 > action[0] > 0.0:
    raise InvalidActionError(
        'Gripper action expected to be within 0 and 1.')

image