soudis / discoursesso

Nextcloud App providing Discourse SSO

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Discourse SSO

This app is designed to allow Discourse instances (discourse.org) to authenticate via a nextcloud instance.

Supports avatar_url for endpoints in the form {url}/{username}
Optional: Add Params for the endpoint (e.g. ?authtoken=xyz&v=3)

Installation

Place this app in nextcloud/apps/

Building the app

The app can be built by using the provided Makefile by running:

make

Configuration

Replace whitespaces in user names and group names (optional)

As discourse does not allow for whitespaces in user names and group IDs you can configure nextcloud to replace whitespaces with a given character in the field "Replace Whitespaces".

For example:

If you put in "_", "Alex Smith" will be replaced with "Alex_Smith".

Extract discourse title from display name (optional)

As there is no "title" field in Nextcloud, you can configure this plugin to extract a title out of the user's display name by putting in a regular expresion in the "Extract title" field. The plugin will then remove the expression if found from the display name and put the expression within the parenthesis "()" of the regular expresion into the title field in Discourse.

For example: /\(([^\\)]*)\)/

If your nextcloud display name would be "Alex (Admin)", your Discourse user name would be "Alex" and your Discourse title would be "Admin".

Avatar URL / Avatar URL Params

Define avatar URL and URL parameters. This will be sent to discourse in the SSO payload in the "avatar_url" field.

Avatar Force Update

Set the "avatar_force_update" field in the SSO payload that is sent to discourse.

Exclude User Groups

Exclude the user's group memberships from the SSO payload. This can be necessary if there are issues with reverse proxy header length.

Known Issues

SECURITY ISSUE! Duplicate E-Mailadresses in Nextcloud user base

There is a security vulnerability if you allow for multiple user accounts with the same e-mail address in nextcloud. The reason is, that the discourse user matching algorithm works like this:

  1. if a user with the given user id is found it matches
  2. if no user with the given id is found it matches by e-mail address

This can lead to the following scenario:

  1. User "alexandra" with e-mail address "alex@example.com" logs on to discourse: discourse does not find an acount for user name "alexandra" or "alex@example.com" a new user account is created
  2. User "alexander" with e-mail address "alex@example.com" logs on to discourse: discourse does not find an account for user id "alexander", but it finds the account "alexandra" by e-mail address and logs the user on to this account

User "alexander" highjacked user account "alexandra" on discourse!

Therefore make sure there is no way to create an account in Nextcloud with an existing e-mail address and do not use this plugin together with local discourse accounts!

Issue with URL decode in Nextcloud 18 and below

There is a bug in nextcloud versions 18 and below that prevents this app from working, please see nextcloud/server#6822

In order to fix this you need to patch the function generateRedirect in the file core/controller/LoginController.php file of the nextcloud server and change the line

$location = $this->urlGenerator->getAbsoluteURL(urldecode($redirectUrl));

to

$location = $this->urlGenerator->getAbsoluteURL($redirectUrl);

Discourse does not allow to be included in iframe

If you want to display discourse within the nextcloud site with the external sites plugin (https://apps.nextcloud.com/apps/external) you would need to set it to open in a separate tab.

Workaround: There is an outdated Discourse plugin to change this, but it may not work with modern browsers: https://github.com/TheBunyip/discourse-allow-same-origin. Feel free to update it and let me know.

About

Nextcloud App providing Discourse SSO

License:GNU Affero General Public License v3.0


Languages

Language:PHP 58.6%Language:Makefile 25.8%Language:JavaScript 14.2%Language:CSS 1.4%