Test and Dockerise

Question

Test and Dockerise

jgamper opened this issue 4 years ago · comments

Jev Gamper commented 4 years ago

There might be an issue with matlab dockerisation to read jp2 images. More details here

vqdang commented 4 years ago

Done

Simon Graham · Answer 1 · Mon Apr 06 2020 19:54:34 GMT+0800 (China Standard Time)

Yes, dockerisation with matlab is definitely not trivial. I am considering simplifying the version that will be released publicly such that it only works with WSIs that can be opened with python API for openslide

Jev Gamper · Answer 2 · Mon Apr 06 2020 20:04:11 GMT+0800 (China Standard Time)

You could leave matlab version in, but just leave it up to user to setup matlab engine

Simon Graham · Answer 3 · Mon Apr 06 2020 20:20:10 GMT+0800 (China Standard Time)

Yes, good idea

vqdang · Answer 4 · Mon Apr 06 2020 21:08:04 GMT+0800 (China Standard Time)

Hi, as this will be published soon, I will delete the pytorch branch prototype that I put here. I don't think anyone have a problem with it? @jgamper @simongraham

Simon Graham · Answer 5 · Mon Apr 06 2020 21:12:56 GMT+0800 (China Standard Time)

Yes, please delete that branch @vqdang. We will release the pytorch version as a separate repo. Try and create a new issue if the subject changes 👍

Simon Graham · Answer 6 · Wed Apr 08 2020 21:48:59 GMT+0800 (China Standard Time)

Are we going to have docker instructions or just environment instructions on the README?

Simon Graham · Answer 7 · Sat Apr 18 2020 00:38:17 GMT+0800 (China Standard Time)

I am closing this issue as the conda environment instructions are sufficient for this purpose.

Jev Gamper · Answer 8 · Sat Apr 18 2020 01:10:29 GMT+0800 (China Standard Time)

If the plan is to still dockerise the repo, i'd suggest keeping the issue open @simongraham