shunnokw / news_app

A news app fully built with RxSwift + MVVM

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

News app

This is the news app for code test challenge.

This app is fully built with RxSwift + MVVM.

Screenshot

Screen recording

https://youtu.be/uHojtg30Xsk

How to run

You need to add a key.plist file in order to run the app and add apiKey as key and you api key as value

Get your api key from https://newsapi.org

Code coverage

Tests covered all business logic (viewModel class).

Services class are not tested because not much logic inside and don't want to test apple's code.

CleanShot 2023-01-23 at 01 41 25@2x

Future improvement

  1. use Swinject to do dependency injection to avoid passing dependency everywhere.
  2. use Yogakit or some other UI framwork to avoid using tidious autolayout code.
  3. use moya to make api call easier and more testable.
  4. include some generic type for NewsResponse object.

About

A news app fully built with RxSwift + MVVM


Languages

Language:Swift 99.3%Language:Ruby 0.7%