Problems converting ASTNode2 to ASTNode with FormulaParserLL3

Question

Problems converting ASTNode2 to ASTNode with FormulaParserLL3

LisaFalk opened this issue 6 years ago · comments

Even though it is not the best idea converting ASTNode2 to ASTNode with FormulaParserLL3 we thought it would be working.
But the formula (A xor B) causes the following exception:
Caused by: org.sbml.jsbml.text.parser.ParseException: Encountered " "xor "" at line 1, column 3.
Was expecting one of:

"+" ...
"^" ...
"-" ...
"*" ...
"/" ...
"%" ...
...
<BOOLEAN_LOGIC> ...
...

Nicolas Rodriguez · Answer 1 · Thu Mar 22 2018 18:35:58 GMT+0800 (China Standard Time)

Thanks for the report, in fact, to support easily 'xor(A, B)' we removed the support for 'A xor B'. You can still use 'XOR' or 'Xor'. Did you wrote this by hand or was it generated by one of the FormulaCompiler ?

Lisa Falk · Answer 2 · Thu Mar 22 2018 21:31:53 GMT+0800 (China Standard Time)

Thank you. It occured by calling the method toFormula() on a ASTLogicalOperatorNode(ASTNode.Type.LOGICAL_XOR).

Nicolas Rodriguez · Answer 3 · Thu Mar 22 2018 21:58:17 GMT+0800 (China Standard Time)

Yes, the ASTNode2 formula compiler would not have been corrected with the latest changes, I will take care of that.

Nicolas Rodriguez · Answer 4 · Thu Mar 22 2018 23:46:25 GMT+0800 (China Standard Time)

It should be fixed now in master.