DPL-631 [BUG] Incorrect evaluation of must_sequence affects both Box buster and Biosero
emrojo opened this issue · comments
Describe the bug
While checking RT769849 we found there is a bug in box buster display that it causes to not display the number of must_sequence samples. This is caused by the way the aggregation of data is performed in: https://github.com/sanger/lighthouse/blob/develop/lighthouse/helpers/general.py at function get_fit_to_pick_samples_and_counts.
The problem is that a must_sequence sample doesnt necesssarily has to be a fit to pick but the aggregation is removing it from the count, and so is displaying must_sequence wrongly.
One way to solve it could be to remove the mongo aggregation side and perform all the calculations of count() in python.
UPDATE The same endpoint is used by Biosero to understand what wells are pickable, so the list of pickable samples is ignoring samples not fit to pick but with must_sequence to true, but they should be displayed
RT Ticket Number
If applicable
To Reproduce
Steps to reproduce the behaviour:
- Go to page '...'
- Click on button '...'
- See error
Expected behaviour
What was expected to happen.
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
- Windows or Mac?
- Browser Chrome, Firefox, Safari or other?
- Browser version (use 'About' to look up)?
Additional context
Add any other context about the problem here.
