ros2 / rviz

Would it be possible to update the crystal branch and release a new version of the debian packages?

With the crystal packages the URDF visualization via /robot_description topic is not working, while with latest sources it does. It would be nice if we could rely on a crystal deb package while the dashing version arrives.

@nzlz do you know which PR fixed the issue? If you can find it, and it can be backported without breaking ABI, then it can be added to the next crystal patch release ros2/ros2#684

Seem like the commit that solved the issue was: 023dddc, coming from PR #378 .

@wjwwood do you think #378 can be backported? The removal 1 and addition of 2 virtual methods would break ABI in a publicly accessible class, but since the class is a Display plugin does that kind of ABI change matter?

rviz/rviz_default_plugins/include/rviz_default_plugins/displays/robot_model/robot_model_display.hpp

Lines 118 to 119 in 314150c

    
           virtual void load_urdf_from_file(const std::string & filepath); 
        
           virtual void load_urdf_from_string(const std::string & robot_description);

@nzlz it looks like Dashing will be the first distro to have that fix. The PR was dropped from Crystal patch release 3 (ros2/ros2#656) because of the API change.

Display the robot description correctly in rviz. Breaks API. Will not be released into Crystal.

    ros2/rviz#382 backports:
        ros2/rviz#378

In the meantime you might have to build rviz_default_plugins from source. https://index.ros.org/doc/ros2/Tutorials/Colcon-Tutorial/

Thanks @sloretz ! we will have to wait a few weeks then.

	virtual void load_urdf_from_file(const std::string & filepath);
	virtual void load_urdf_from_string(const std::string & robot_description);

Update crystal deb packages - Request