Deadman not sending stop command (joy)

[Guillermo Ruffino]

I might be doing something wrong, even looking at the source code I can't figure out how to get it to work like I want:

I press button, hold down, then move the robot around with joy axes, then stop axes, robot stops release button -> all is ok.
But if I'm moving the robot with the axes, then release the button, the robot keeps moving for a while until I believe my engine controller stops moving because it stops receiving cmd_vel commands, i.e. it never receives a cmd_vel with target velocity of 0.

I was using joy_teleop before and it worked this way, the cmd_vel 0 was sent on button release.

Now this teleop tools seems more flexible and useful for me.

In any case I can send a PR to support this if it will be welcomed.

Relevant config is just this:

teleop:
  joy_move:
    type: topic
    message_type: geometry_msgs/Twist
    topic_name: cmd_vel
    deadman_buttons: [4]
    axis_mappings:
      -
        axis: 1
        target: linear.x
        scale: 0.7
      -
        axis: 0
        target: angular.z
        scale: 0.5

[Guillermo Ruffino]

I've sent a PR for this #47