Noetic release

Question

Noetic release

TheDelus opened this issue 4 years ago · comments

Fabian Freihube commented 4 years ago

Hi, is a release for ros-noetic planned for this package?

G.A. vd. Hoorn · Answer 1 · Tue Jun 02 2020 23:15:03 GMT+0800 (China Standard Time)

See my response here: gavanderhoorn/industrial_robot_status_controller#5 (comment).

Dmitri · Answer 2 · Fri Jun 26 2020 08:29:56 GMT+0800 (China Standard Time)

Would this orocos/orocos_kinematics_dynamics#218 mean that kdl is no longer blocking?

If that's the case, I'd be happy to make the changes and submit a PR following http://wiki.ros.org/noetic/Migration#Use_Orocos_KDL_and_BFL_rosdep_keys

That way it would be ready to go once MoveIt is released for Noetic (would it need a different branch since it would break the current one?).

Simon Schmeisser · Answer 3 · Mon Aug 17 2020 17:51:53 GMT+0800 (China Standard Time)

@EvilPictureBook yes, please open a PR!

I also noticed that industrial_trajectory_filters does not compile due to a API change in MoveIt. We need to add this virtual function:

virtual void planning_request_adapter::PlanningRequestAdapter::initialize(const ros::NodeHandle&)

Sean Yen · Answer 4 · Tue Aug 25 2020 04:36:00 GMT+0800 (China Standard Time)

Just wondering, is there any plans to have a dedicate branch for melodic or noetic? Would it be welcome to consider Windows port fixes as it moves to newer releases?

Tyler Weaver · Answer 5 · Thu Oct 01 2020 05:59:18 GMT+0800 (China Standard Time)

MoveIt is now released for Noetic, so this can go forward if that was what was blocking it.

Felix Messmer · Answer 6 · Thu Jan 14 2021 20:58:28 GMT+0800 (China Standard Time)

there seems to be a noetic compatibility pr even: #258
what's the status of the noetic release?
any chance simple_message gets released as a partial release?

Simon Schmeisser · Answer 7 · Fri Jan 15 2021 20:50:23 GMT+0800 (China Standard Time)

I haven't received any feedback to my PR so far unfortunately ... maybe you could get it a review @fmessmer and then @gavanderhoorn would merge it?

Felix Messmer · Answer 8 · Fri Jan 15 2021 21:19:21 GMT+0800 (China Standard Time)

I haven't received any feedback to my PR so far unfortunately ... maybe you could get it a review @fmessmer and then @gavanderhoorn would merge it?

I'm mainly interested in seeing simple_message released....I have no insight into these industrial-core packages as I'm only trying to satisfy our noetic dependencies...thus, unfortunately, I don't see myself qualified to review...but simple_message doesn't seem to be blocked as it already seems noetic-ready...thus, I asked for a partial release...sorry

Felix Messmer · Answer 9 · Tue Jan 19 2021 16:41:31 GMT+0800 (China Standard Time)

I can confirm that (at least) simple_message compiles on noetic from ros-industrial/industrial_core#kinetic-devel
👉 so a partial release should be possible for simple_message

I can also confirm that with #258 all packages of industrial_core compile on noetic
👉 so a full release should be possible after merging #258

G.A. vd. Hoorn · Answer 10 · Mon Jun 28 2021 20:40:50 GMT+0800 (China Standard Time)

Done: ros/rosdistro#30044.

Even though it hasn't been merged yet, I'm going to close this issue, as it's basically just 'formalities' at this point.

G.A. vd. Hoorn · Answer 11 · Mon Jun 28 2021 20:41:30 GMT+0800 (China Standard Time)

Note: I opted to release without #271 merged. It'll already unblock releases of other packages and as that PR potentially changes behaviour, I thought it'd be good to first get a release out.