gitignore _deps/ folder
FirefoxMetzger opened this issue · comments
Building the development version of gym-ignition generated a folder called _deps/ at the root of the repository which is currently not in the .gitignore. It contains some ycm related files which all appear to be generated.
Should we add the folder to .gitignore?
This should not happen. We use CMake in such a way that no build artifacts escape from the build folder. The _deps folder is populated with external dependencies downloaded by CMake, the entire process should entirely happen in build and not leak stuff outside.
My impression is that CMake was called in the wrong way, what happens to me by time to time is that I type cmake . in the source tree, and this would result to the creation of CMake artifacts outside the build. How did you invoke CMake?
Indeed, there is another _deps folder inside build that contains the same files. I guess it is an artifact of me trying to figure out why the build failed previously. It's entirely possible that I accidentally called cmake . in the root folder and not in build.
I wiped the folder, re-cloned the repo, and re-ran cmake .. This time only one _deps folder was generated and it was inside build (where it should be) I'll close this issue; sorry for the noise.