rickomax / psxprev

PSXPREV - Playstation (PSX) Files Previewer/Extractor

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Cleanup disposable resources on failure to parse

trigger-segfault opened this issue · comments

Currently, when parsing a file fails, an exception is thrown and nothing is done after that besides continuing to the next offset. However, certain classes may have been created that need to properly be disposed of, namely textures and their Bitmap class.

I've also noticed that Graphics is not disposed of after drawing to VRAM. I'm not familiar with whether that needs to be disposed or not, but it's another thing to consider.

This has been partially implemented by PR #77. Cleanup on parse failure still needs to be handled.