TSVTaxonomyFormat should check for empty column labels

Question

TSVTaxonomyFormat should check for empty column labels

thermokarst opened this issue 6 years ago · comments

Matthew Ryan Dillon commented 6 years ago

The sniffer currently just checks for the presence header labels, but doesn't ensure that anything beyond the two record header labels are not empty strings.

This recently came up on the forum.

Turan Naimey · Answer 1 · Tue Feb 19 2019 04:47:12 GMT+0800 (China Standard Time)

@thermokarst I'm interested in this. Can you assign me to this issue? Thanks

Matthew Ryan Dillon · Answer 2 · Tue Feb 19 2019 21:13:54 GMT+0800 (China Standard Time)

@turanoo --- it would be nice to update the sniff method referenced above to use the new _validate_ API (sniff has been deprecated). You can see an example of that process in #195.

Jorden · Answer 3 · Sun May 19 2019 02:34:19 GMT+0800 (China Standard Time)

I can take a stab at this @thermokarst!

Matthew Ryan Dillon · Answer 4 · Fri Nov 01 2019 00:10:02 GMT+0800 (China Standard Time)

Fixed in #221