ppy / osu-performance

Calculates user performance aggregates from scores

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Stop score overwrite if pp of the play is lower

Syphist opened this issue · comments

This one is self explanatory, stopping the score from being internally overwritten if the pp from the play is lower should be a given. You achieved the score previously, therefore it should count to your pp. You can still keep the pp from the previous score though if an "internal" mod like Touch Device was created. For the sake of the this proposal we will call it "TopPP". Upon a score overwrite a simple if statement could check if the pp is higher or lower. If it is lower, take the old performance, add the "TopPP" mod to it and then save it with that mod combo and save the new score with the mod combo it was submitted with. The "TopPP" score wouldn't need to show up on leaderboards if you want things to be consistent and you could easily show on the website it is no longer their top score on that map with that mod combo by making said mod show up with an icon on the site. This would allow for the best of both worlds with this system.

This proposal would accomplish 2 things. It would no longer discourage players from trying to improve a performance on a map they enjoy, and it would also no longer confuse a new player for losing rank or pp from improving their score.

commented

I think this would be a good idea,

What about (the lack of) overwrite in the other direction? If this is implemented, should it also be that if a play is set that is lower score but higher pp than a previous play, it receive the "TopPP" mod and gain the player pp?

commented

Quintec Yeah, that's a good idea!

This is not a simple thing to do, else it would have already been done. We will likely address this in lazer, but not sooner, as it carries many implications at a UX, infra, and every client level.

commented

@peppy yeah, it'd also have to balance how to fix the accuracy counter,

could you make it so we lose ranked score if we get less score but more pp that would be fine with pretty much everyone since not many people care about score because that doesn't contribute to any of the skill rankings

right now it overwrites the pp and you can lose pp and gain score