Giters

pokusew / nfc-pcsc

Easy reading and writing NFC tags and cards in Node.js

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Require in non-babel env needs .default suffix

Khasanboy opened this issue · comments

commented

I am trying to create application using Electron. In the beginning I was getting problem with node Module versions that was expecting 51 but required 53. I installed Electron 1.5.1 and that error is fixed but now I am getting error that says:

TypeError: NFC is not a constructor

I just used your example and error is coming from this line:

const nfc = new NFC();

did I miss something or is it about node native modules ?

Thanks in advance

commented

Hi @Khasanboy,

I addressed the problem. It is caused by Babel export default transform behaviour (see http://stackoverflow.com/a/33705077).

If you use Babel transpiler (with ES6 modules support) for you app code too, you can import it like import NFC from 'nfc-pcsc'.

Otherwise you must use const NFC = require('nfc-pcsc').default. (add .default).

I know, that's not very intuitive.

Thank you very much for drawing my attention to this problem. I'll prepare a solution (maybe using babel-plugin-add-module-exports and add info to docs.

To this problem:

I am trying to create application using Electron. In the beginning I was getting problem with node Module versions that was expecting 51 but required 53. I installed Electron 1.5.1 and that error is fixed...

Node Native modules must be built with the correct version of Node.js, in which they will be used.

So, if you install this library with npm, it is built with your machine's Node.js version. But then, you are using the library in Electron and Electron uses its own version of Node.js internally.

So after installing a library with Node Native Module, you must rebuild the source with correct Electron headers.
(for example you can run this node-gyp command: cd node_modules/nfc-pcsc && node-gyp rebuild --target=[electronVersion] --arch=[arch] --dist-url=https://atom.io/download/atom-shell)

The usage with Electron is described in README FAQs section Can I use this library in my Electron app?.
There is also a link to Using Native Node Modules guide in Electron documentation to fully understand the problematic.

Hope it helps.

commented

Thanks, This fixed the problem

commented

Solved, but introduced a breaking change, see How do I require/import this library? in README.