Deprecated "dgcMatrix"

[Alexander Bender]

Hi Pierre-Luc,

fyi, the Matrix package >= 1.5.0 has deprecated the as(., "dgCMatrix") syntax, now erroring if that is used. It now must be as(., "CsparseMatrix"). I would therefore suggest to update the respective lines in the source and require Matrix to be >= 1.5.0 in the DESCRIPTION.

I do not have a MRE at hand now, but once you update Matrix you get something like:

> bp  <- BiocParallel::MulticoreParam(mc_workers, RNGseed=1234)
> sce <- scDblFinder::scDblFinder(sce, clusters="cluster", samples="zt", BPPARAM=bp)
Error: BiocParallel errors
  2 remote errors, element index: 1, 2
  0 unevaluated and other errors
  first remote error:
Error in value[[3L]](cond): An error occured while processing sample 'zt1':
Error: as(<dgeMatrix>, "dgCMatrix") is deprecated since Matrix 1.5-0; do as(., "CsparseMatrix") instead

best,
-Alex

[Pierre-Luc]

Hi Alex,
thanks for pointing this out.
I pushed the change, and since this is quite critical I've also altered the stable Bioc 3.16 release.
(Haven't changed the explicit Matrix dependency yet, since CsparseMatrix did work in previous Matrix versions)
Best,
Pierre-Luc

[Alexander Bender]

Great, thanks for the prompt reply!