Improve the structure of DenovoSig
Hu-JIN opened this issue · comments
Hu Jin commented
We should follow more closely the design of sklearn estimators: https://scikit-learn.org/stable/developers/develop.html.
For example:
- Remove parameter validation from
__init__
. - Add a reasonable set_params method.
- Move the input X from
__init__
to fit().
Ideally, we should also do this for other classes, e.g., MVNMF, NMF, etc.