Giters

openhwgroup / core-v-verif

Functional verification project for the CORE-V family of RISC-V cores.

Home Page:https://docs.openhwgroup.org/projects/core-v-verif/en/latest/index.html

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Spike tandem] Runtime exceptions in CVA6 Spike + VCS-UVM tandem simulations

zchamski opened this issue · comments

commented

Issue observed and reproducible on recent versions of core-v-verif code including the latest master (commit 4e6e860): when attemptring a CVA6 Spike tandem run with VCS-UVM (envariable DV_SIMULATORS contains vcs-uvm and SPIKE_TANDEM=1), VCS fails with an uncaught DPI runtime exception:

terminate called after throwing an instance of 'std::runtime_error'
  what():  memory size must be a positive multiple of 4 KiB

Error-[DPI-UED] C++ Exception detected                                                                                                                                        
  Import DPI routine invoked at file
  '...../cva6/verif/sim//../core-v-verif/lib/uvm_components/uvmc_rvfi_reference_model/rvfi_spike.sv'(line
  76) has C++ exceptions not caught. C++ exceptions shall not propagate out of
  any imported subroutine.
  Fix it in DPI-C code before running simulation.

Type

  • Functionally incorrect behavior

Steps to Reproduce

  1. URL to branch that exhibits the issue: master branch at https://github.com/openhwgroup/core-v-verif (the result above was obtained with 4e6e860).
  2. Command line: at cva6 toplevel export DV_SIMULATORS=vcs-uvm SPIKE_TANDEM=1 ; bash verif/regress/smoke-tests.sh
commented

Further investigation gives more insigth into the nature of the failure. Here's a relevant .log.iss logfile fragment with extra messages added:

2368 [SPIKE] Starting 'spike_create'...
2369 [SPIKE] htif_args = {
2370   /........../cva6/verif/sim/out_2024-05-21/directed_asm_tests/add.o,
2371 }
2372 [SPIKE] Proc 0 | ISA: RV64IMAFDC_zba_zbb_zbc_zbs_zcb_zicsr_zicntr PRIV: MSU
2373 <stdin>:39.20-43.7: Warning (simple_bus_reg): /soc/clint@33554432: simple-bus unit address format error, expected "2000000"
2374 [SPIKE] PASS: Got back default /top/dram_base value = 0x80000000!
2375 [SPIKE] Simulation::Simulation after parse_params: /top/dram_base value = 0x69a098211923f469!
2376 [SPIKE] Simulation::Simulation: Before make_mems
2377 [SPIKE] Initializing memories...
2378 [SPIKE] ROM content head(8) = 13 04 10 00 13 14 f4 01
2379 [SPIKE] BootROM initialization done.
2380 [SPIKE] Setting up DRAM... Got size == 6542914149569485696 (0x5acd19c0d0f75b80)
2381 terminate called after throwing an instance of 'std::runtime_error'
2382   what():  memory size must be a positive multiple of 4 KiB
2383 
2384 Error-[DPI-UED] C++ Exception detected
2385   Import DPI routine invoked at file
2386   '/........../cva6/verif/sim//../core-v-verif/lib/uvm_components/uvmc_rvfi_reference_model/rvfi_spike.sv'(line
2387   76) has C++ exceptions not caught. C++ exceptions shall not propagate out of
2388   any imported subroutine.
2389   Fix it in DPI-C code before running simulation.

Clearly, DRAM base address and DRAM size values are not valid, pointing to Spike parameter management.

commented

The fix in PR openhwgroup/cva6#2153 solves the problems of random (sic!) runtime exceptions in Spike/VCS-UVM tandem code caused by invalid DRAM parameters. @AyoubJalali , can you please rebase your IRQ code (or cherry-pick the commit from openhwgroup/cva6#2153) and check if the DPI interface works OK now?

commented

The fix in PR openhwgroup/cva6#2153 solves the problems of random (sic!) runtime exceptions in Spike/VCS-UVM tandem code caused by invalid DRAM parameters. @AyoubJalali , can you please rebase your IRQ code (or cherry-pick the commit from openhwgroup/cva6#2153) and check if the DPI interface works OK now?

on it !!
Thanks

commented

Hi @AyoubJalali, any updates on the status?

commented

Fixed !!