Convert Entity stats to a Hash

Question

Convert Entity stats to a Hash

nskins opened this issue 7 years ago · comments

Nicholas Skinsacos commented 7 years ago

Each of the Entity stats (hp, max_hp, attack, defense, agility) should be contained within a single Hash called stats. Then we can reference the particular stat as the key (e.g. stats[:hp]) to retrieve it. This will be useful in #alter_stats of the Equippable module. The current implementation of this function references each stat individually (ugly). Instead, we can loop through all the keys in stats and update them as appropriate.

Also, update the tests in #alter_stats to include some cases of modifying hp and max_hp.

Pull requests can be sent to the entity-stats branch.

Jeff Hostetler · Answer 1 · Tue May 23 2017 22:55:40 GMT+0800 (China Standard Time)

Hey just found this project and would like to contribute. Mind if I pick this one up?

Nicholas Skinsacos · Answer 2 · Tue May 23 2017 22:58:22 GMT+0800 (China Standard Time)

Yup. All yours!

…

On May 23, 2017 10:55 AM, "Jeff-Hostetler" ***@***.***> wrote: Hey just found this project and would like to contribute. Mind if I pick this one up? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#103 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHgDjFt5RNH1eyfa1bg3LfbnhkMXKgBiks5r8vNxgaJpZM4Nhbkl> .