nfdi4plants / ARCtrl

Library for management of Annotated Research Contexts (ARCs) using an in-memory representation and runtime-agnostic contract systems.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[BUG] Investigation table view not showing studies

ZimmerD opened this issue · comments

OS and framework information (please complete the following information):
Windows 10, ARCitect release 0.0.27

Describe the bug

  • A clear and concise description of what the bug is

I have an ARC with one study, and 5 Assays, while the assays show up as "registered Assay identifiers" when clicking on the study (screenshot 1), the study is missing from "registered Study identifiers" when clicking on the Investigation/Root (screenshot 2)

  • Steps to reproduce
  1. Create and ARC
  2. Create a study, and one or more assays linked to said study
  • Screenshots

image

image

HAve you registered the study in the investigation? Can you verify it is correctly written into the .xlsx file? (👀 click "Explorer" on the left sidebar to open the ARC in explorer)

We are currently working on a ISA-light format which will no longer handle isa file registration in a ARC context and instead handle all assays/studies in an ARC as registered

I added the study through the ARCitect interface and would have assumed that it is automatically registered as a study of this investigation - as I have no option to decide otherwise as it is the case for assays. However, when checking the investigation.xlsx it is also not mentioned.
The word study is not found in the investigation file, maybe this is done by design as all studies of an arc are implictly registered to this investigation? If so we might remove the "registered studies element" from the investigation table view.

I see! Will look into this!

This should be correctly handled on ARCitect side and the studies not showing are propably a sideeffect of the experimental ISA-light syntax.

I will transfer this issue to ARCtrl to have a further look:

future me @Freymaurer and @HLWeil. This is the code used in ARCitect:

const addStudy_ = async (identifier: string, skip_io: boolean | void)=>{
  const study = new ArcStudy(identifier,identifier);
  ArcControlService.props.arc.ISA.AddRegisteredStudy(study)
  if(!skip_io){
    await ArcControlService.writeARC();
    await ArcControlService.readARC();
    AppProperties.active_study = identifier;
  }
};

So the underlying issue is propably the isa light writer

Yep agree..