Giters

msberends / AMR

Functions to simplify and standardise antimicrobial resistance (AMR) data analysis and to work with microbial and antimicrobial properties by using evidence-based methods, as described in https://doi.org/10.18637/jss.v104.i03.

Home Page:https://msberends.github.io/AMR/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add Ukrainian translation

msberends opened this issue · comments

commented

Had contact with @gxpcluster to add Ukrainian translation. Fantastic news! We'll gladly incorporate it into the package.

There's 2 ways to go forward:

  1. Just paste the contents of an edited version of data-raw/translations.tsv here, containing an extra column "uk" (we follow ISO 639-1) with the translated strings. We can then merge it into our project manually.
  2. Fork this project (I see this is already done, great!), edit the file github.com/gxpcluster/AMR/data-raw/translations.tsv and create a Pull Request. We can then merge it into our project automatically.

For us, the second option would be ideal, but the first is less work for you probably, which is also perfectly fine for us.

If there are any questions, please let me know!

commented

Hi Matthijs.

Thank you for the instructions. I will try the second option and send a pull request. Is it better to use development or master branch?

We also have a question about the phrase "Antimicrobial Interpretation". If I understand correctly, this is the label for the x-axis on the plot. Could you please explain this phrase, because we have several options for its translation and we would like to choose the best one.

We have also found that plots have another labels and titles that are not presented in tsv file. Such as:

  • Percentage
  • MIC values of
  • Resistance Overview of
  • Disk zones of

(here)
Can we add these phrases to the edited file?
I would also like to ask you to attach one or two examples of such plots.

Thank you.

commented

Good points! I’ll try to respond to your questions in the next coming week.

commented

Dear Matthijs,
We completed the translation of the tsv file, but would like to wait for your response to make the final corrections.
We look forward to hearing from you.

commented

That's great news!

Please use the development branch to update translations.tsv. We will update the current git flow to not rely on the development branch, it's not very convenient and the website is not generated automatically at the moment. This will be solved using GitHub Actions in the next months.

Regarding your questions:

We also have a question about the phrase "Antimicrobial Interpretation". If I understand correctly, this is the label for the x-axis on the plot. Could you please explain this phrase, because we have several options for its translation and we would like to choose the best one.

Indeed, it is used for the x-axis when plotting R/SI values using either plot(), barplot() (both base R), or autoplot() (ggplot2). This is the only occurrence, so it will be used like this to give you an example:

library(AMR)
values <- random_rsi(100)
barplot(values)

image

ggplot2::autoplot(values)

image

We have also found that plots have another labels and titles that are not presented in tsv file. Such as:

  • Percentage
  • MIC values of
  • Resistance Overview of
  • Disk zones of

Nice catch! Only "Percentage" must be translated, the other 3 are leftovers and will be removed in a future version. I will add the translation of "Percentage" of the other languages.

The only place where "Percentage" is being used is when plotting R/SI values using plot():

plot(values)

image

commented

Dear Matthijs,

Thank you for all the explanations. We will introduce corresponding changes, and today I will try to make a pull request.

commented

Pull request is done. Everything seems to be ok.

commented

Fixed in #67