typo in function name in tutorial for "Predicting future antimicrobial resistance using regression models"

[Daniel Weiand]

RE: typo in function name in tutorial for "Predicting future antimicrobial resistance using regression models"

@ https://msberends.github.io/AMR/articles/resistance_predict.html

e.g.

# choose for error bars instead of a ribbon
ggplot_sir_predict(predict_TZP, ribbon = FALSE)

should be

# choose for error bars instead of a ribbon
ggplot_rsi_predict(predict_TZP, ribbon = FALSE)

This typo in the function name is repeated several times over in the tutorial.

As always, thanks for this amazing package!

[Matthijs Berends]

It is, and not without reason 😄

We changed all mentions of ‘rsi’ to ‘sir’ in AMR v2, which was released last March. See our Changelog: https://msberends.github.io/AMR/news/index.html#sir-vs-rsi-2-0-0

The old functions are still functional, and will remain so for a while. If you use them, you’ll get a warning that they are replaced. So I assume you’re on an older version then?

[Daniel Weiand]

Thanks for the link! I use multiple PCs for my work in R, and use the {renv} package. Definitely guilty of avoiding updating packages where possible to avoid breaking changes, but I can see here that you have made lots of improvements, making the update worth it! Best wishes, Dan From: Dr. Matthijs Berends ***@***.***> Sent: Thursday, May 18, 2023 9:23 PM To: msberends/AMR ***@***.***> Cc: WEIAND, Daniel (THE NEWCASTLE UPON TYNE HOSPITALS NHS FOUNDATION TRUST) ***@***.***>; Author ***@***.***> Subject: Re: [msberends/AMR] typo in function name in tutorial for "Predicting future antimicrobial resistance using regression models" (Issue #111) This message originated from outside of NHSmail. Please do not click links or open attachments unless you recognise the sender and know the content is safe. It is, and not without reason 😄 We changed all mentions of ‘rsi’ to ‘sir’ in AMR v2, which was released last March. See our Changelog: https://msberends.github.io/AMR/news/index.html#sir-vs-rsi-2-0-0 The old functions are still functional, and will remain so for a while. If you use them, you’ll get a warning that they are replaced. So I assume you’re on an older version then? — Reply to this email directly, view it on GitHub<#111 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AVYNORM7TRIPCAGW6X3OCMTXG2ALRANCNFSM6AAAAAAYG4POTM>. You are receiving this because you authored the thread.Message ID: ***@***.******@***.***>> ************************************************************************************** ****************************** This message may contain confidential information. If you are not the intended recipient please: i) inform the sender that you have received the message in error before deleting it; and ii) do not disclose, copy or distribute information in this e-mail or take any action in relation to its content (to do so is strictly prohibited and may be unlawful). Thank you for your co-operation. NHSmail is the secure email, collaboration and directory service available for all NHS staff in England. NHSmail is approved for exchanging patient data and other sensitive information with NHSmail and other accredited email services. For more information and to find out how you can switch visit Joining NHSmail – NHSmail Support<https://support.nhs.net/article-categories/joining-nhsmail/>

[Matthijs Berends]

No problem! Yes, it's surely worth it I think 😄

I you run into anything, please let us know!