Release geometric_shapes into ROS Noetic?

Question

Release geometric_shapes into ROS Noetic?

sloretz opened this issue 4 years ago · comments

Would you mind releasing geometric_shapes to ROS Noetic? It looks like all of its dependencies have been released, and recursively 41 repos need it.

Simon Schmeisser · Answer 1 · Thu Apr 23 2020 23:40:55 GMT+0800 (China Standard Time)

probably also something for your weekend @rhaschke ?

Robert Haschke · Answer 2 · Fri Apr 24 2020 11:45:10 GMT+0800 (China Standard Time)

Let's see how much time my weekend actually has...
It would be great of course to have all the pending PRs merged before a release... @peci1, @v4hn what is missing to this end?

Michael Görner · Answer 3 · Fri Apr 24 2020 13:31:11 GMT+0800 (China Standard Time)

On Thu, Apr 23, 2020 at 08:45:22PM -0700, Robert Haschke wrote: Let's see how much time my weekend actually has... It would be great of course to have all the pending PRs merged before a release... @peci1, @v4hn what is missing to this end?

Someone to review and test them. In my opinion, you might release it already to enable dependency resolution though. We should have a followup release soon though.

Martin Pecka · Answer 4 · Fri Apr 24 2020 16:42:18 GMT+0800 (China Standard Time)

Yeah, I think all my PRs are ready to be merged and reviews are the only missing thing. I'll be available today and on Saturday. On Sunday I probably won't be able to quickly respond...

Michael Görner · Answer 5 · Fri Apr 24 2020 23:48:16 GMT+0800 (China Standard Time)

I spend half the day reviewing all open requests here and peci just addressed my few comments.

There are 6 open and approved pull-requests lying around waiting for a second approval to merge.

Martin Pecka · Answer 6 · Sun Apr 26 2020 08:29:05 GMT+0800 (China Standard Time)

Would it be possible to leave at least a week or so since noetic-devel is created to the actual API/ABI freeze? There are things that'd benefit from breaking API/ABI, but as there is no noetic-devel yet, it's impossible to send PRs...

Robert Haschke · Answer 7 · Sun Apr 26 2020 14:19:44 GMT+0800 (China Standard Time)

No problem to postpone until next week. geometric_shapes is mainly blocking the MoveIt release, which is not going to be released into Noetic within the next few weeks.

Shane Loretz · Answer 8 · Wed May 13 2020 00:20:53 GMT+0800 (China Standard Time)

Friendly ping, anything geometric_shapes needs before release?

Robert Haschke · Answer 9 · Wed May 13 2020 01:02:07 GMT+0800 (China Standard Time)

@v4hn, do we want to merge the open PR(s) before a Noetic release?

Wolfgang Merkt · Answer 10 · Sat May 23 2020 02:56:24 GMT+0800 (China Standard Time)

Friendly ping, are there other PRs you'd like to merge before releasing? I am happy to help out with testing or in another capacity :-)

Martin Pecka · Answer 11 · Sat May 23 2020 02:59:25 GMT+0800 (China Standard Time)

I think #144 should definitely be merged before release. It was requested in moveit/moveit#1964 and the changes in moveit will depend on it.

Robert Haschke · Answer 12 · Mon May 25 2020 15:53:30 GMT+0800 (China Standard Time)

Release PR: ros/rosdistro#25051