meganrogge / template-string-converter

Autocorrect from quotes to backticks

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Does not handle nested quotes

bduffany opened this issue · comments

Input:

'Foo "bar${}" baz'

Actual result:

'Foo `bar${}` baz'

Expected result:

`Foo "bar${}" baz`

Thanks for the issue. I've made this setting template-string-converter.convertOutermostQuotes, which is false by default. going to do a bit more testing then will push the changes.
recording (35)

Just curious, why false by default? To me it seems like most people would want this to be true.

I don't want to surprise people with new behavior. I can see the argument for setting it to true by default though.