Doesn't work with Github

Question

Doesn't work with Github

lkuchenb opened this issue 9 years ago · comments

Leon Kuchenbecker commented 9 years ago

When I tried using it for github 2FA, the generated keys don't work. Google Authenticator works though.

Mark McAvoy · Answer 1 · Sun Oct 11 2015 03:51:14 GMT+0800 (China Standard Time)

I'm looking into this issue. How did you provision the token, manually or by scanning the QR code?

Mark McAvoy · Answer 2 · Sun Oct 11 2015 04:58:51 GMT+0800 (China Standard Time)

I think I have located the issue.

So when you scan or enter the key provided on Github its lower case base32. This is where the bug is, Android Token fails to make this upper case before parsing the input.

When I manually create the token and enter the key as upper case it works as expected and the OTP matches that of the Google Authenticator (as created by the QR).

I will create a fix. Additionally I will make the add token input default to base32 as the input format for direct entered keys since most keys are given in base32.

Leon Kuchenbecker · Answer 3 · Wed Oct 14 2015 21:28:38 GMT+0800 (China Standard Time)

Thanks, works fine now!