Deviget challenge: show 50 top posts from Reddit.
We would like to have you complete the following code test so we can evaluate your iOS skills. Please place your code in a public Github repository and commit each step of your process so we can review it.
Your assignment is to create a simple Reddit client that shows the top 50 entries from Reddit
- ✅ Create a Public repository
- ✅ Commit each step of your process so we can follow your thought process.
-
✅ Assume the latest platform and use Swift
-
✅ Use UITableView / UICollectionView to arrange the data.
-
✅ Please refrain from using any dependency manager [cocoapods / carthage / etc], instead, use URLSession
-
✅ Support all Device Orientation
-
✅ Support all Devices screen (iPhone/iPad)
-
✅ Use Storyboards
-
✅ The app should be able to show data from each entry such as:
- ✅Title at its full length, so take this into account when sizing your cells)
- ✅Author
- ✅entry date, following a format like “x hours ago”
- ✅A thumbnail for those who have a picture.
- ✅Number of comments
- ✅Unread status
-
✅In addition, for those having a picture (besides the thumbnail), please allow the user to tap on the thumbnail to be sent to the full sized picture. You don’t have to implement the IMGUR API, so just opening the URL would be OK.
- ✅ Pull to Refresh
- ⬜️ Pagination support: Given that we're showing only the 50 top posts, I assigned low priority to this. More on this on the "Some comments" section (link).
- ✅ Saving pictures in the picture gallery (Handled directly by SFSafariViewController "share").
- 👷 App state-preservation/restoration.
- ✅ Read/Unread & Dismissed posts are saved locally using UserDefaults.
- ⬜️ Posts are not stored locally. This will be an offline mode. I assigned low priority to this because we're showing only 50 posts. It makes a lot of sense to include offline mode alongside pagination).
- ✅Indicator of unread/read post (updated status, after post it’s selected)
- ✅ Dismiss Post Button (remove the cell from list. Animations required ✅)
- ✅ Dismiss All Button (remove all posts. Animations required ✅)
- ✅ Support split layout (left side: all posts / right side: detail post)
- [Reddit API](http://www.reddit.com/dev/api)
- [Apigee](https://apigee.com/console/reddit)
- Example JSON file (top.json) is listed.
- Example Video of functionality is attached
You do not need to fully complete the challenge. We suggest not to spend more than 5 hours total, which can be done over the course of 2 days. Please make commits as often as possible so we can see the time you spent and please do not make one commit. We will evaluate the code and time spent.
What we want to see is how well you handle yourself given the time you spend on the problem, how you think, and how you prioritize when time is insufficient to solve everything.
Please email your solution as soon as you have completed the challenge or the time is up.
- Based on the idea of "showing the 50 top reddit posts", I assigned low priority to pagination (because I can ask for all of them with one request), and to offline mode (while it's not explicitly mentioned on the requirements, requirements talk about persisting the app state).
I think both features are related. If we support to see MORE than 50 posts, performance on the quantity and size of requests will gain importance, and we will need pagination.
In order to implement this, I can use the before
and after
query params (link). I'm currently storing the id of the posts (link
will be a better name than post
because it would be consistent with Reddit domain names), so, I can generate the full name to use as value of before
and after
preprending a "t3_"
to that id (link).
In this case, doing a pull to refresh should fetch posts before the first post known by the the app (it can happen that more that N posts were published between "pull-to-refresh"es, and in that case we don't want to miss any post); and scrolling beyond the last cell, will should fetch post after the last post known by the app.
I think that reducing the scope to shown ONLY THE TOP 50 is a good idea, because showing MORE THAN 50 can be handled as another feature/US. I think is a good US slicing.
-
I developed and included some functionality not explicitly listed on the requirements, because I think it's importante for the user experience with the app:
-
"confirmation alerts" for destructive operations (dismiss post, and dismiss ALL posts).
-
empty view for posts list. While always will be top posts from reddit, after dismissing all of the no one is shown. I this case I offer the user the possibility of 'undismiss' all previously dismissed posts.
-
empty view on post detail. On iPad, if no post is selected there's nothing to show. In this case I suggest the usser to pick a post from the list on the left.
-
-
Save image to device can be done directly from the "full screen image" (using SFSafariViewController) shown when the user tap on the thumbnail on the post detail screen.
-
There are tags (link) on the repo, each one with a stable (but reduced) version. I sliced the functionality in a way that I could always "release" (show the stable version of app) if needed. Each tag shows kind of a milestone:
-
I think the 5 hour deadline correspond to (this tag), I spent some more time (1-2 hours) finishing the "dismiss post feature" and completing this read.me.